follow

#42 9term extra echo

Reported anonymously 2010-01-29

in cooked mode (e.g. with rc), 9term echoes the intput incorrecrly. e.g.

; echo fu
echo fu
fu

Attachments

Comments and changes

1. #1 Ethan Grammatikidis

   written 2010-01-29

   Ditto, except I don't see it all the time. I find it much more common on my older / single core machines (< 500MHz) than on my multi-core.
2. #2 Anonymous

   written 2010-01-30

   stty -echo
3. #3 Anonymous

   written 2010-03-19

   stty -echo disables not only the extra echo, but i also cannot see anything i type. another thing i noticed, under freebsd it does not show the extra echo, but under (arch) linux it does...
4. #4 Anonymous

   written 2010-03-21

   upon further investigation, it looks like a problem in 9term.c after line 515. it seems that

   if(s)
                 setecho(sfd, s);
   

   (which resets the echo setting of the terminal) gets executed before the command has a chance to run. if i insert a sleep statement, the extra echo is not shown anymore.

   --- a/src/cmd/9term/9term.c     Fri Mar 19 13:11:12 2010 -0700
   +++ b/src/cmd/9term/9term.c     Sun Mar 21 11:54:27 2010 +0100
   @@ -514,6 +514,7 @@
                   s = setecho(sfd, 0);
                   if(write(rcfd, pair.s, pair.ns) < 0)
                           threadexitsall(nil);
   +               sleep(50);
                   if(s)
                           setecho(sfd, s);
           }
   
5. #5 Anonymous

   written 2010-03-21

   needed to change sleep(50) to sleep(1) in my previous post, otherwise the echo is not reset on long command output.
6. #6 Anonymous

   written 2010-05-20

   looks like forced cooked mode (via '-c' with latest commit) , followed by 'stty -echo' solves the problem
7. #7 Russ Cox

   written 2011-10-14

   • Changed status from new to resolved.

Verification: Please write the text from the image in the box (letters only)

Is that you, Humanoid? Is this me?

• Cancel